Github user wgtmac commented on a diff in the pull request:
https://github.com/apache/orc/pull/116#discussion_r114447159
--- Diff: c++/src/Statistics.hh ---
@@ -41,49 +41,181 @@ namespace orc {
};
/**
+ * Internal Statistics Implementation
+ */
+
+ template <typename T>
+ class InternalStatisticsImpl {
+ private:
+ bool hasNull_;
--- End diff --
For the naming here, underscore is not consistent with the current code
base. (Only current XXColumnStatistics classes use "_" in the beginning of
members but I don't think they should be fixed)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
