Github user majetideepak commented on a diff in the pull request:
https://github.com/apache/orc/pull/116#discussion_r114463789
--- Diff: c++/src/Statistics.hh ---
@@ -41,49 +41,181 @@ namespace orc {
};
/**
+ * Internal Statistics Implementation
+ */
+
+ template <typename T>
+ class InternalStatisticsImpl {
+ private:
+ bool hasNull_;
--- End diff --
This is according to the google coding style we agreed upon. I am going to
slowly change the entire code base to follow the google coding style. The style
recommends class variables to end with an `_`
https://google.github.io/styleguide/cppguide.html#Variable_Names
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
