Github user xndai commented on a diff in the pull request:
https://github.com/apache/orc/pull/116#discussion_r115346953
--- Diff: c++/src/Statistics.hh ---
@@ -41,49 +41,181 @@ namespace orc {
};
/**
+ * Internal Statistics Implementation
+ */
+
+ template <typename T>
+ class InternalStatisticsImpl {
+ private:
+ bool hasNull_;
--- End diff --
Not sure if this is right time to enforce a new coding style. We have an
existing code base roughly about 10,000 lines. It's quite a bit of effort to
convert existing code into proposed style. What's the problem with current
style? Or ask it differently - what is the benefit of moving over to google
style?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
