Github user omalley commented on a diff in the pull request:
https://github.com/apache/orc/pull/265#discussion_r186114158
--- Diff: c++/test/CreateTestFiles.cc ---
@@ -31,8 +31,8 @@
void writeCustomOrcFile(const std::string& filename,
const orc::proto::Metadata& metadata,
const orc::proto::Footer& footer,
- const std::vector<uint>& version,
- uint writerVersion) {
+ const std::vector<unsigned>& version,
--- End diff --
We generally prefer to use explicitly sized types, so uint64_t or uint32_t
would be better.
---
