Github user rip-nsk commented on a diff in the pull request:

    https://github.com/apache/orc/pull/265#discussion_r186487106
  
    --- Diff: c++/src/Timezone.cc ---
    @@ -710,7 +710,11 @@ namespace orc {
        * Get the local timezone.
        */
       const Timezone& getLocalTimezone() {
    +#ifdef _MSC_VER
    +    return getTimezoneByName("UTC");
    --- End diff --
    
    http://unicode.org/cldr/data/common/supplemental/windowsZones.xml - here is 
a mapping of windows <=> *nix time zones, 
    and here - https://github.com/google/cctz - "timezone" library which 
probably is a best choice (BTW https://github.com/google/cctz/issues/53).
    Anyway,  it is non trivial work which I think does not related to orc 
directly.
    I believe it should be customer decision how to pass/extract timestamps 
from orc library and any timezone conversions should be done on customer side.


---

Reply via email to