dongjoon-hyun commented on a change in pull request #543:
URL: https://github.com/apache/orc/pull/543#discussion_r511540943
##########
File path: c++/src/Statistics.hh
##########
@@ -1298,9 +1356,17 @@ namespace orc {
if (_stats.hasMinimum()) {
tsStats->set_minimumutc(_stats.getMinimum());
tsStats->set_maximumutc(_stats.getMaximum());
+ if (_minimumNano != DEFAULT_MIN_NANOS) {
+ tsStats->set_minimumnanos(_minimumNano + 1);
Review comment:
Please add a comment about the reason why we use `+1` here, too.
Otherwise, it looks like a magic number.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
