dongjoon-hyun commented on a change in pull request #543:
URL: https://github.com/apache/orc/pull/543#discussion_r513174009
##########
File path: c++/src/sargs/PredicateLeaf.cc
##########
@@ -542,11 +543,21 @@ namespace orc {
colStats.timestampstatistics().has_minimumutc() &&
colStats.timestampstatistics().has_maximumutc()) {
const auto& stats = colStats.timestampstatistics();
+ int32_t minNano = stats.has_minimumnanos() ?
+ stats.minimumnanos() - 1 : 0;
+ int32_t maxNano = stats.has_maximumnanos() ?
+ stats.maximumnanos() - 1 : 999999;
Review comment:
Shall we use `DEFAULT_MAX_NANOS` instead of `999999`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
