dongjoon-hyun commented on a change in pull request #588:
URL: https://github.com/apache/orc/pull/588#discussion_r549244315
##########
File path: java/core/src/java/org/apache/orc/impl/ColumnStatisticsImpl.java
##########
@@ -2100,6 +2100,12 @@ public static ColumnStatisticsImpl
deserialize(TypeDescription schema,
return deserialize(schema, stats, true, true);
}
+ public static ColumnStatisticsImpl deserialize(TypeDescription schema,
+ OrcProto.ColumnStatistics
stats,
+ boolean
writerUsedProlepticGregorian) {
+ return deserialize(schema, stats, writerUsedProlepticGregorian, true);
+ }
+
Review comment:
If you don't mind, shall we remove this addition in order to keep the
simplicity?
This new `static` function is used once and we can remove this new API like
the following.
```java
- ColumnStatistics cs = ColumnStatisticsImpl.deserialize(null, statsProto,
writerUsedProlepticGregorian);
+ ColumnStatistics cs = ColumnStatisticsImpl.deserialize(null, statsProto,
writerUsedProlepticGregorian, true);
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
