dongjoon-hyun commented on a change in pull request #588:
URL: https://github.com/apache/orc/pull/588#discussion_r549571330
##########
File path: java/core/src/test/org/apache/orc/impl/TestRecordReaderImpl.java
##########
@@ -593,7 +593,22 @@ static TruthValue
evaluateTimestamp(OrcProto.ColumnStatistics stats,
return RecordReaderImpl.evaluatePredicateProto(stats, predicate, null,
encoding, null,
include135 ? OrcFile.WriterVersion.ORC_135:
OrcFile.WriterVersion.ORC_101,
- TypeDescription.createTimestamp(), useUTCTimestamp);
+ TypeDescription.createTimestamp(), true, useUTCTimestamp);
+ }
+
+ static TruthValue
evaluateTimestampWithWriterCalendar(OrcProto.ColumnStatistics stats,
+ PredicateLeaf
predicate,
+ boolean include135,
+ boolean
writerUsedProlepticGregorian,
+ boolean
useUTCTimestamp) {
+ OrcProto.ColumnEncoding encoding =
+ OrcProto.ColumnEncoding.newBuilder()
Review comment:
Could you follow the indentation style around here like line 577 and
line 590?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
