pgaref commented on pull request #586: URL: https://github.com/apache/orc/pull/586#issuecomment-753857936
> @pgaref Thank you to check the RLE path. I have read the patch code for [ORC-616](https://issues.apache.org/jira/browse/ORC-616). I found it use DIRECT code instead. The solution in #586 may be better for encoding. Can I revert the [ORC-616](https://issues.apache.org/jira/browse/ORC-616) and change it to my solution? Could you agree it? If you agree it, I will write the code to update the pull request. Hey @chaoyli -- definitely agree that ORC-616 is not ideal in terms of encoding. Can you also check #601 and my [comment above?](https://github.com/apache/orc/pull/586#issuecomment-753592692) before updating the PR -- I believe that checking for negative numbers is sufficient here. Thanks for working on this :) ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
