pgaref commented on pull request #586: URL: https://github.com/apache/orc/pull/586#issuecomment-754073505
> @pgaref OK, I will check it. I have a question to consult. Although I have not construct a case about large positive integer, you can ensure that large position integer will be encoded as PatchedBase? [testPatchedBaseMax4](https://github.com/apache/orc/blob/60c9e9757ffb766edaaaeb7bed9c565a0316612d/java/core/src/test/org/apache/orc/TestNewIntegerEncoding.java#L1168) should already take care of that but sure we can add a more specific test too -- lets make sure these tests are replicated on the Cpp side as well ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
