pgaref commented on a change in pull request #607:
URL: https://github.com/apache/orc/pull/607#discussion_r555677598
##########
File path: java/tools/pom.xml
##########
@@ -57,13 +57,13 @@
<dependency>
<groupId>org.apache.hadoop</groupId>
<artifactId>hadoop-common</artifactId>
- <version>${hadoop.version}</version>
+ <version>${tools.hadoop.version}</version>
<scope>compile</scope>
</dependency>
<dependency>
<groupId>org.apache.hadoop</groupId>
- <artifactId>hadoop-hdfs</artifactId>
- <version>${hadoop.version}</version>
+ <artifactId>hadoop-hdfs-client</artifactId>
Review comment:
Tests seem to pass for 3.2.2 -- I am not sure we should have an explicit
hadoop version for tool though.
Any reason we are not bumping hadoop.version project wide? We could still
keep the min supported version to 2.2 right?
```
<min.hadoop.version>2.2.0</min.hadoop.version>
<hadoop.version>2.7.3</hadoop.version>
<tools.hadoop.version>3.2.2</tools.hadoop.version>
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
