dongjoon-hyun commented on a change in pull request #607:
URL: https://github.com/apache/orc/pull/607#discussion_r555923333
##########
File path: java/tools/pom.xml
##########
@@ -57,13 +57,13 @@
<dependency>
<groupId>org.apache.hadoop</groupId>
<artifactId>hadoop-common</artifactId>
- <version>${hadoop.version}</version>
+ <version>${tools.hadoop.version}</version>
<scope>compile</scope>
</dependency>
<dependency>
<groupId>org.apache.hadoop</groupId>
- <artifactId>hadoop-hdfs</artifactId>
- <version>${hadoop.version}</version>
+ <artifactId>hadoop-hdfs-client</artifactId>
Review comment:
Do you think it's safe? Of course, we should bump `hadoop.version`
later, but I don't think that is trivial like this, @pgaref .
Hadoop 3 has many breaking changes like
https://github.com/apache/orc/pull/608 is also a behavior change from Hadoop
layer. This PR is designed by @omalley 's decision. He explicitly mentioned
`tools` jar's Hadoop version, not the all Hadoop version.
> We should upgrade the version of Hadoop used for the tools jar to the
higher 2.7.7 from 2.7.3.
I believe we can upgrade `tools` first and do the main later with more
testing.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
