pavibhai commented on a change in pull request #634:
URL: https://github.com/apache/orc/pull/634#discussion_r564675626



##########
File path: java/core/src/java/org/apache/orc/impl/RecordReaderImpl.java
##########
@@ -104,17 +104,10 @@
    */
   static int findColumns(SchemaEvolution evolution,

Review comment:
       @dongjoon-hyun My guess is that there are some unit tests that need 
fixing. I had to do the same here in ORC that is the reason for that new 
`checkEvolutionPosn` method in the test class.
   
   @pgaref Updated the javadoc for the method.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to