pavibhai commented on a change in pull request #634:
URL: https://github.com/apache/orc/pull/634#discussion_r564660301
##########
File path: java/core/src/java/org/apache/orc/impl/RecordReaderImpl.java
##########
@@ -104,17 +104,10 @@
*/
static int findColumns(SchemaEvolution evolution,
String columnName) {
- try {
- TypeDescription readerColumn =
evolution.getReaderBaseSchema().findSubtype(
- columnName, evolution.isSchemaEvolutionCaseAware);
- TypeDescription fileColumn = evolution.getFileType(readerColumn);
- return fileColumn == null ? -1 : fileColumn.getId();
- } catch (IllegalArgumentException e) {
- if (LOG.isDebugEnabled()){
- LOG.debug("{}", e.getMessage());
- }
- return -1;
- }
+ TypeDescription readerColumn = evolution.getReaderBaseSchema().findSubtype(
+ columnName, evolution.isSchemaEvolutionCaseAware);
+ TypeDescription fileColumn = evolution.getFileType(readerColumn);
+ return fileColumn == null ? -1 : fileColumn.getId();
Review comment:
Added the test
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
