dongjoon-hyun commented on a change in pull request #635:
URL: https://github.com/apache/orc/pull/635#discussion_r565703336
##########
File path: java/core/src/java/org/apache/orc/Reader.java
##########
@@ -265,7 +269,7 @@ public Options schema(TypeDescription schema) {
*
* @return this
*/
- public Options setRowFilter(String[] filterColumnNames,
Consumer<VectorizedRowBatch> filterCallback) {
+ public Options setRowFilter(String[] filterColumnNames,
Consumer<FilterContext> filterCallback) {
Review comment:
This looks like a breaking API change.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
