pavibhai commented on a change in pull request #635:
URL: https://github.com/apache/orc/pull/635#discussion_r566071643
##########
File path: java/core/src/java/org/apache/orc/impl/TreeReaderFactory.java
##########
@@ -67,7 +70,7 @@
Set<Integer> getColumnFilterIds();
- Consumer<VectorizedRowBatch> getColumnFilterCallback();
+ Consumer<org.apache.orc.filter.FilterContext> getColumnFilterCallback();
Review comment:
This class also uses `org.apache.hadoop.hive.ql.io.filter.FilterContext`
that is why this is fully qualified. I am happy to consider a different name
e.g. `FilterInput`.
We can make this change after we have an approach on how to handle the
breaking change of `Consumer<VectorizedRowBatch>` -> `Consumer<FilterContext>`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
