pgaref commented on a change in pull request #648:
URL: https://github.com/apache/orc/pull/648#discussion_r586361659
##########
File path: c++/src/sargs/SargsApplier.cc
##########
@@ -25,7 +26,13 @@ namespace orc {
const std::string& colName) {
for (uint64_t i = 0; i != type.getSubtypeCount(); ++i) {
if (type.getFieldName(i) == colName) {
- return type.getSubtype(i)->getColumnId();
+ if (type.getKind() == CHAR || type.getKind() == VARCHAR) {
Review comment:
Shall we leave this to the
[consumer](https://github.com/apache/orc/blob/295ea5be6c2ae643bb3c3ca6db7b018aeb51bebc/java/core/src/java/org/apache/orc/impl/SchemaEvolution.java#L378)?
We dont have anything similar on the Java side.
We probably should address this as part of ORC-612
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
