pgaref commented on a change in pull request #648:
URL: https://github.com/apache/orc/pull/648#discussion_r589630797
##########
File path: c++/include/orc/Reader.hh
##########
@@ -538,6 +549,12 @@ namespace orc {
*/
virtual void seekToRow(uint64_t rowNumber) = 0;
+ /**
+ * If PPD is enabled, returns true and store number of selected RGs and
+ * number of evaluated RGs into the stats pair; otherwise returns false.
+ */
+ virtual bool getPPDStats(std::pair<uint64_t, uint64_t>& stats) const = 0;
Review comment:
Agreed, lets remove this for now and use a separate ticket to track.
I believe the remaining changes are ready to be merged after that.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
