pavibhai commented on a change in pull request #653:
URL: https://github.com/apache/orc/pull/653#discussion_r599987036



##########
File path: 
java/core/src/java/org/apache/orc/impl/reader/tree/StructBatchReader.java
##########
@@ -76,4 +83,31 @@ public void nextBatch(VectorizedRowBatch batch, int 
batchSize) throws IOExceptio
       }
     }
   }
+
+  @Override
+  public void startStripe(StripePlanner planner) throws IOException {

Review comment:
       Good idea. Pushed the implementation into PrimitiveBatchReader.
   
   Now only the methods `setVectorColumnCount` and `resetBatch` methods are 
implemented in BatchReader.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to