pavibhai commented on a change in pull request #653:
URL: https://github.com/apache/orc/pull/653#discussion_r599991511
##########
File path: java/core/src/java/org/apache/orc/impl/InStream.java
##########
@@ -621,9 +631,20 @@ private ByteBuffer slice(int chunkLength) throws
IOException {
chunkLength + " bytes");
}
- void seek(long desired) throws IOException {
+ /**
+ * Seek to the desired chunk based on the input position.
+ *
+ * @param desired position in the compressed stream
+ * @return Indicates whether a seek was performed or not
+ * @throws IOException when seeking outside the stream bounds
+ */
+ boolean seek(long desired) throws IOException {
if (desired == 0 && bytes == null) {
- return;
+ return false;
Review comment:
Removed ORC-758 references
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
