noirello commented on a change in pull request #679:
URL: https://github.com/apache/orc/pull/679#discussion_r609418988
##########
File path: c++/src/Compression.cc
##########
@@ -36,6 +36,10 @@
#define ZSTD_CLEVEL_DEFAULT 3
#endif
+#ifndef LZ4_ACCELERATION_MAX
+#define LZ4_ACCELERATION_MAX 65537
Review comment:
These macros are defined in `lz4.c` instead of the header file for some
reason. That's why I needed to redefine them here. Their values are looked up
from the
docs/[sources](https://github.com/lz4/lz4/blob/bdc9d3b0c10cbf7e1ff40fc6e27dad5f693a00e7/lib/lz4.c#L47-L57).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
