pavibhai commented on a change in pull request #668:
URL: https://github.com/apache/orc/pull/668#discussion_r635377594
##########
File path: java/core/src/java/org/apache/orc/impl/RecordReaderImpl.java
##########
@@ -958,19 +981,21 @@ public SargApplier(SearchArgument sarg,
filterColumns = mapSargColumnsToOrcInternalColIdx(sargLeaves,
evolution);
this.rowIndexStride = rowIndexStride;
+ this.evolution = evolution;
+ exceptionCount = new long[sargLeaves.size()];
+ this.useUTCTimestamp = useUTCTimestamp;
+ }
+
+ public void setRowIndexCols(boolean[] rowIndexCols) {
Review comment:
It is related. I see that the rowIndexCols are not used within the
SArgApplier. Additionally now the RowIndexCols is decided both by the SArgs and
the Filters so I wanted to pull this out of the SArgApplier into
RecordReaderImpl where it is used.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
