pgaref commented on a change in pull request #668:
URL: https://github.com/apache/orc/pull/668#discussion_r640567316
##########
File path: java/core/src/java/org/apache/orc/impl/TreeReaderFactory.java
##########
@@ -189,12 +192,34 @@ public boolean useProlepticGregorian() {
public boolean fileUsedProlepticGregorian() {
return fileUsedProlepticGregorian;
}
+
+ @Override
+ public TypeReader.ReaderCategory getReaderCategory(int columnId) {
+ TypeReader.ReaderCategory result;
+ if (getColumnFilterCallback() == null ||
getColumnFilterIds().contains(columnId)) {
Review comment:
Not sure why consider getColumnFilterCallback null case here?
When there is not filter set we consider all ReaderCategories to be
FILTER_PARENT or FILTER_CHILD?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
