pgaref commented on a change in pull request #668:
URL: https://github.com/apache/orc/pull/668#discussion_r641434362
##########
File path: java/core/src/java/org/apache/orc/impl/reader/tree/TypeReader.java
##########
@@ -24,22 +25,70 @@
import org.apache.orc.impl.reader.StripePlanner;
import java.io.IOException;
+import java.util.EnumSet;
public interface TypeReader {
void checkEncoding(OrcProto.ColumnEncoding encoding) throws IOException;
- void startStripe(StripePlanner planner) throws IOException;
+ void startStripe(StripePlanner planner, ReadPhase readPhase) throws
IOException;
- void seek(PositionProvider[] index) throws IOException;
+ void seek(PositionProvider[] index, ReadPhase readPhase) throws IOException;
- void seek(PositionProvider index) throws IOException;
+ void seek(PositionProvider index, ReadPhase readPhase) throws IOException;
- void skipRows(long rows) throws IOException;
+ void skipRows(long rows, ReadPhase readPhase) throws IOException;
void nextVector(ColumnVector previous,
boolean[] isNull,
int batchSize,
- FilterContext filterContext) throws IOException;
+ FilterContext filterContext,
+ ReadPhase readPhase) throws IOException;
int getColumnId();
Review comment:
Lets do that as part of the follow up PR -- this part of the code is not
released yet (only part of main branch) so we have more flexibility
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
