pgaref commented on pull request #668: URL: https://github.com/apache/orc/pull/668#issuecomment-849599674
> > Hey @pavibhai thanks updating this! Any remaining comments to address? Is this ready for a final review? > > @pgaref thanks for following up. I think most of the changes are complete. The key item that I have not yet done is splitting the PR. > > I have had some discussions with @omalley and based on that the key change you will see in the PR right now is the separation of ReadLevel into ReadCategory and ReadPhase. > > Hope that makes sense. Hey @pavibhai thanks for all the work here! Latest PR looks pretty good to me, ReadPhase and ReadCategory make the logic easier to follow. Left some mostly minor comments but I believe we should merge this shortly :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
