pgaref commented on a change in pull request #734:
URL: https://github.com/apache/orc/pull/734#discussion_r665224823
##########
File path: java/core/src/java/org/apache/orc/impl/SerializationUtils.java
##########
@@ -287,27 +293,24 @@ public long zigzagDecode(long val) {
* @param p - percentile value (>=0.0 to <=1.0)
* @return pth percentile bits
*/
- public int percentileBits(long[] data, int offset, int length,
- double p) {
+ public int percentileBits(long[] data, int offset, int length, double p) {
if ((p > 1.0) || (p <= 0.0)) {
return -1;
}
- // histogram that store the encoded bit requirement for each values.
- // maximum number of bits that can encoded is 32 (refer FixedBitSizes)
- int[] hist = new int[32];
+ Arrays.fill(this.histBuffer, 0);
Review comment:
Any reason we removed the comment here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
