belugabehr commented on pull request #734: URL: https://github.com/apache/orc/pull/734#issuecomment-875591895
> Hey @belugabehr changes LGTM -- just wondering if we can/should incorporate the Perf tests you did when discovered this? @pgaref Hey, thanks for taking a look. Nothing special here. I am just slowly working through the `core-benchmark` module. I've examined the write side a bit (see: #734 #735 #736) and hope to find time next week to look at the read side. To be clear, I think the biggest savings of this PR comes from using `Long.numberOfLeadingZeros` instead of implementing a loop that can loop as many as 64-times per value written. The rest of the stuff I changed based on manual inspection of the code. I did not test each piece individually, but as I mentioned, after making these changes this method didn't even register in the performance capture. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
