guiyanakuang commented on pull request #907: URL: https://github.com/apache/orc/pull/907#issuecomment-922565756
> Sorry for late review. BTW, do we need to update only `encoding` and `isFixedDelta`? What about other variables like `fixedDelta`? `fixedDelta` initialized to 0, and `writeValues()` ends with a call to `clear()` to set the necessary variables to their default values. `fixedDelta=0` is exactly what we need. This is also the case with `bitsDeltaMax`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
