guiyanakuang commented on a change in pull request #907:
URL: https://github.com/apache/orc/pull/907#discussion_r711835232
##########
File path: java/core/src/java/org/apache/orc/impl/RunLengthIntegerWriterV2.java
##########
@@ -755,7 +755,8 @@ public void write(long val) throws IOException {
// if fixed runs reached max repeat length then write values
if (fixedRunLength == MAX_SCOPE) {
- determineEncoding();
+ encoding = EncodingType.DELTA;
+ isFixedDelta = true;
Review comment:
However, java and C++ have different styles of processing
```java
//Java
if (prevDelta == 0 && currentDelta == 0) {
// fixed delta run
} else {
// variable delta run
}
```
```C++
//c++
if (prevDelta == 0 && currentDelta == 0) {
// fixed delta run
return;
}
// variable delta run
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
