Definitely not. Especially now that we found what the 2s hit was on OS X, it's kind of sad to see that gain squandered by something as trivial as the welcome note.
Andi.. On Thu, 10 Nov 2005, Alec Flett wrote:
This change caused a big jump in startup time (about 3 seconds) - but not because of anything wrong with the code that was added. (i.e. John was correctly fixing a bug assigned to him) Its pretty obvious that the change is because we're now rendering something in the detail view, whereas before we were not... (Though I'm sure its expected that we would take a hit, but its surprising that it is as much as it is - about 3.6 seconds on windows!) I also noticed that some of the other tests like "Resize calendar with 3k event calendar" jumped as much as 71% - but my guess is that its because we're now resizing all the widgets in the detail view, in addition to the calendar itself. So this leads me to two questions: 1) Are we willing to take the startup hit to show the welcome note? (especially important since this affects the absolute first time that the user starts the application - talk about making a first impression!) 2) Do we need to adjust any of the other tests to clear the detail view before running the test, or do we adjust our definitions for what consistitutes each test? (which is to say, the tests now include something rendered in the detail view) I'm guessing that we want to adjust our definitions, rather than try to work with an empty detail view. Alec [email protected] wrote: Revision 8233 Author john Date 2005-11-10 10:58:01 -0800 (Thu, 10 Nov 2005) Log Message Bug #4082: Welcome note should be displayed in the DV on startup. r=alecf Modified Paths * trunk/chandler/parcels/osaf/app/__init__.py * trunk/chandler/parcels/osaf/views/main/summaryblocks.py Diff Modified: trunk/chandler/parcels/osaf/app/__init__.py (8232 => 8233) --- trunk/chandler/parcels/osaf/app/__init__.py 2005-11-10 18:21:32 UTC (rev 8232) +++ trunk/chandler/parcels/osaf/app/__init__.py 2005-11-10 18:58:01 UTC (rev 8233) @@ -101,7 +101,7 @@ datetime.date.today(), datetime.time(12, tzinfo=ICUtzinfo.getDefault())) - welcome = pim.CalendarEvent.update(parcel, 'WelcomeEvent', + WelcomeEvent = pim.CalendarEvent.update(parcel, 'WelcomeEvent', displayName=_(u'Welcome to Chandler 0.5'), startTime=noonToday, duration=datetime.timedelta(minutes=120), @@ -133,7 +133,7 @@ The Chandler Team""") - welcome.body = welcome.getAttributeAspect('body', 'type').makeValue(body) + WelcomeEvent.body = WelcomeEvent.getAttributeAspect('body', 'type').makeValue(body) # Set up the main web server Modified: trunk/chandler/parcels/osaf/views/main/summaryblocks.py (8232 => 8233) --- trunk/chandler/parcels/osaf/views/main/summaryblocks.py 2005-11-10 18:21:32 UTC (rev 8232) +++ trunk/chandler/parcels/osaf/views/main/summaryblocks.py 2005-11-10 18:58:01 UTC (rev 8233) @@ -81,7 +81,13 @@ tzCharacterStyle=DefaultCharacterStyle, stretchFactor=0) MainCalendarControl = MainCalendarControlT.install(parcel) + WelcomeEvent = schema.ns("osaf.app", view).WelcomeEvent + MainCalendarControl.selection = [WelcomeEvent] + CalendarDetailTPB = TrunkParentBlock.template('CalendarDetailTPB', + trunkDelegate=detailTrunkDelegate).install(parcel) + CalendarDetailTPB.TPBSelectedItem = WelcomeEvent + CalendarSummaryView = \ CalendarContainer.template('CalendarSummaryView', calendarControl=MainCalendarControl, ________________________________________________________________________ _______________________________________________ Commits mailing list [email protected] http://lists.osafoundation.org/mailman/listinfo/commits
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ Open Source Applications Foundation "Dev" mailing list http://lists.osafoundation.org/mailman/listinfo/dev
