+1 On 17 January 2018 at 05:42, Leif Hedstrom <[email protected]> wrote:
> > > > On Jan 12, 2018, at 2:36 PM, Otto van der Schaaf <[email protected]> > wrote: > > > > Hi All, > > > > I would like to change review policy for the incubator-pagespeed-* > > repositories. > > Please cast your +1/0/-1 vote on the following: > > > > Currently I think this is not explicitly defined, but we wait for at > least > > one peer review > > before merging code, akin to RTC. > > It would be good to publicly document the way our project work with > regard > > to this for > > new and potential contributors. > > I think we have two distinct commit policies to choose from [1]: > > > > As there's going to be lots of small changes, to keep some velocity I am > > proposing > > to switch to Commit-Then-Review (at least temporary). > > > Yeh, I’m +1 on this. > > I think long term, requiring at least one review on Github PRs would be a > good idea. > > — Leif > >
