Thanks to all for participating in the vote. The vote has now closed. The results are:
Binding Votes: +1 [6] 0 [0] -1 [0] The vote is successful -- the project is now in CTR-mode. I'll document that in the wiki. We probably want to discuss review policy again after we have merged all the code changes for ASF policy compliance. Otto On Wed, Jan 17, 2018 at 6:18 PM Kees Spoelstra <[email protected]> wrote: > +1 > > On 17 January 2018 at 05:42, Leif Hedstrom <[email protected]> wrote: > > > > > > > > On Jan 12, 2018, at 2:36 PM, Otto van der Schaaf <[email protected]> > > wrote: > > > > > > Hi All, > > > > > > I would like to change review policy for the incubator-pagespeed-* > > > repositories. > > > Please cast your +1/0/-1 vote on the following: > > > > > > Currently I think this is not explicitly defined, but we wait for at > > least > > > one peer review > > > before merging code, akin to RTC. > > > It would be good to publicly document the way our project work with > > regard > > > to this for > > > new and potential contributors. > > > I think we have two distinct commit policies to choose from [1]: > > > > > > As there's going to be lots of small changes, to keep some velocity I > am > > > proposing > > > to switch to Commit-Then-Review (at least temporary). > > > > > > Yeh, I’m +1 on this. > > > > I think long term, requiring at least one review on Github PRs would be a > > good idea. > > > > — Leif > > > > >
