oschaaf commented on issue #1775: Deadlock in shm statistics URL: https://github.com/apache/incubator-pagespeed-mod/issues/1775#issuecomment-394672273 Anything suspicious in the logs that you can correlate? In any case, the code involving manipulation of `locks_currently_held_` in `NamedLockScheduleRewriteController` looks tricky / complex to me. Especially when manipulation of the counter happens simultaneously with other child processes shutting down / restarting. Looking at it, I think manipulation of `locks_currently_held_` can be safely commented out. You could try if patching in the following eliminates the deadlocks: https://github.com/apache/incubator-pagespeed-mod/compare/master...oschaaf-avoid-locks-currently-held Longer term, I'm thinking that maybe we want to keep the statistics thread local for manipulation, and sync with shared mem ones (for internal use and display in the admin pages) periodically.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
