oschaaf commented on issue #1775: Deadlock in shm statistics
URL: 
https://github.com/apache/incubator-pagespeed-mod/issues/1775#issuecomment-396632426
 
 
   I think that the patch may improve odds, but it's not going to reliably 
solve the problem. The code all looks good afaict, and that makes me think that 
the scenario @jmarantz suggested, a process killed while holding a lock, may be 
a realistic explanation.
   
   Also, I worked on some shutdown stuff for ngx_pagespeed [1], which I think 
actually implemented some of what you suggest.  Perhaps it is translatable to 
the httpd world.. 
   
   One thing I remember however, is that the stock http fetcher, Serf, is not 
always able to cancel outstanding fetches in a timely manner. This could still 
cause trouble. Maybe moving the fetching over to the experimental central 
controller process could be part of a solution to that. With the image 
optimization and the fetching happening in another process, we should be able 
to shut down consistently quickly in all cases.
   
   
https://github.com/apache/incubator-pagespeed-ngx/commit/d7f1c0dc4817f153da29ced58882cb0bc9787c2c

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to