jmarantz commented on a change in pull request #1854: Added support for
specifying a TTL for redis keys (Fixes #1704)
URL:
https://github.com/apache/incubator-pagespeed-mod/pull/1854#discussion_r251652644
##########
File path: pagespeed/system/redis_cache_test.cc
##########
@@ -48,6 +48,7 @@ namespace {
static const int kReconnectionDelayMs = 10;
static const int kTimeoutUs = 100 * Timer::kMsUs;
static const int kDatabaseIndex[] = {0, 1};
+ static const int kTTL[] = {0};
Review comment:
Why did you make this an array? Also, units :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
