jmarantz commented on a change in pull request #1854: Added support for
specifying a TTL for redis keys (Fixes #1704)
URL:
https://github.com/apache/incubator-pagespeed-mod/pull/1854#discussion_r251650420
##########
File path: pagespeed/system/redis_cache.h
##########
@@ -82,7 +82,7 @@ class RedisCache : public CacheInterface {
RedisCache(StringPiece host, int port, ThreadSystem* thread_system,
MessageHandler* message_handler, Timer* timer,
int64 reconnection_delay_ms, int64 timeout_us,
- Statistics* stats, int database_index);
+ Statistics* stats, int database_index, int ttl);
Review comment:
can you put the units into the variable name, e.g. ttl_sec ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
