Lofesa commented on issue #1899: data-srcset in img and amp-img URL: https://github.com/apache/incubator-pagespeed-mod/pull/1899#issuecomment-503656246 Hi @jmarantz I run pagespeed_automatic_test locally and only get one test fail, but this test will fail in a plain new cloned repo: `[ FAILED ] InprocessShm/SharedMemStatisticsTestTemplate/0.TestHistogramRender, where TypeParam = net_instaweb::(anonymous namespace)::InProcessSharedMemEnv` All test i have added are ok: ``` [----------] 141 tests from ImageRewriteTest [ RUN ] ImageRewriteTest.ImgTag [ OK ] ImageRewriteTest.ImgTag (73 ms) [ RUN ] ImageRewriteTest.ImgSrcSet [ OK ] ImageRewriteTest.ImgSrcSet (17 ms) [ RUN ] ImageRewriteTest.ImgDataSrcSet [ OK ] ImageRewriteTest.ImgDataSrcSet (17 ms) [ RUN ] ImageRewriteTest.ImgAmpSrcSet [ OK ] ImageRewriteTest.ImgAmpSrcSet (17 ms) ``` RE: when it is serving Amp, and maybe it should rewrite amp-img But not. The only way the amp-img is rewrited is with `UrlValuedAttribute amp-img src image` whitout this PR only the src is rewrited, with this PR src and srcset get writed.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
