Lofesa commented on issue #1899: data-srcset in img and amp-img URL: https://github.com/apache/incubator-pagespeed-mod/pull/1899#issuecomment-504363998 > > > I misread the code earlier, we're not in the loop that iterates the attributes when we start rewrites of the `srcset`s. Sorry about the noise, that is fine to leave as-is. > Thanks for adding the tests! But now the rewrite of srcset and data-srcset is behind the loop and we can simplify the double if. We can use the if .. else, the for...if or use the ternary operator. Personally prefer the ternary operator, less lines = simply to read.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
