oschaaf commented on a change in pull request #1899: data-srcset in img and
amp-img
URL:
https://github.com/apache/incubator-pagespeed-mod/pull/1899#discussion_r296157777
##########
File path: net/instaweb/rewriter/image_rewrite_filter.cc
##########
@@ -2136,13 +2136,18 @@ void ImageRewriteFilter::StartElementImpl(HtmlElement*
element) {
}
BeginRewriteImageUrl(element, attributes[i].url);
- }
-
- if (element->keyword() == HtmlName::kImg) {
+
+
HtmlElement::Attribute* srcset = element->FindAttribute(HtmlName::kSrcset);
+ HtmlElement::Attribute* datasrcset =
element->FindAttribute(HtmlName::kDataSrcset);
Review comment:
nit: Can you fix the indentation here? Sorry about dragging on about that,
but we're pretty strict about style; consistency helps everyone a lot.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
