oschaaf commented on a change in pull request #1899: data-srcset in img and amp-img URL: https://github.com/apache/incubator-pagespeed-mod/pull/1899#discussion_r296158869
########## File path: pagespeed/automatic/system_tests/responsive_images.sh ########## @@ -35,4 +35,7 @@ start_test rewrite_images can rewrite srcset itself URL=$TEST_ROOT/image_rewriting/srcset.html?PageSpeedFilters=+rewrite_images,+debug fetch_until -save $URL 'grep -c xPuzzle.*1x.*xCuppa.*2x' 1 +start_test rewrite_images_datasrcset can rewrite data-srcset itself +URL=$TEST_ROOT/image_rewriting/data-srcset.html?PageSpeedFilters=+rewrite_images,+debug +fetch_until -save $URL 'grep -c srcset.*xPuzzle.*1x.*xCuppa.*2x' 2 Review comment: Should we grep for `data-srcset` instead of just `src-set`? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
