oschaaf commented on a change in pull request #1906: Adding zlib to bazel build URL: https://github.com/apache/incubator-pagespeed-mod/pull/1906#discussion_r300716830
########## File path: bazel/zlib.bzl ########## @@ -0,0 +1,35 @@ +zlib_build_rule = """ +cc_library( + name = "zlib", + srcs = glob([ + "src/adler32.c", + "src/compress.c", + "src/crc32.c", + "src/deflate.c", + "src/infback.c", + "src/inffast.c", + "src/inflate.c", + "src/inftrees.c", + "src/trees.c", + "src/zutil.c", + ]), + hdrs = glob([ + "src/crc32.h", + "src/deflate.h", + "src/inffast.h", + "src/inffixed.h", + "src/inflate.h", + "src/inftrees.h", + "src/trees.h", + "src/zconf.h", + "src/zlib.h", + "src/zutil.h", + "src/gzguts.h", + ]), + copts = [ + "-w", Review comment: consider filing an issue in the bazel milestone to track - investigating if we need/want these options? - revisit this to see if we need to consider the `USE_SYSTEM_ZLIB` flag ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
