oschaaf commented on a change in pull request #1906: Adding zlib to bazel build
URL:
https://github.com/apache/incubator-pagespeed-mod/pull/1906#discussion_r300997530
##########
File path: bazel/repositories.bzl
##########
@@ -16,3 +18,10 @@ def mod_pagespeed_dependencies():
url = "https://github.com/google/brotli/archive/%s.tar.gz"; %
BROTLI_COMMIT,
)
+ http_archive(
+ name = "zlib",
Review comment:
I think the `.a` name is determined below via
```
cc_library(
name = "zlib",
```
regardless, lgtm as-is, thanks for adding the todo
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
