hallerm commented on issue #1987: Improve beacon data decoding URL: https://github.com/apache/incubator-pagespeed-mod/pull/1987#issuecomment-612159586 The updated version only changes which classes exception of exceptions are being thrown. The default is to `#define JSON_USE_EXCEPTION 1`. In the current version it will then throw `std::runtime_error`. In the new version this is changed to `Json::Exception` extends `std::exception`. This is why the catch is for `std::exception&`: so that if JsonCpp is upgraded it does not quietly break. Regarding tests, I am having difficulty figuring out how to run the tests. The instructions at https://github.com/apache/incubator-pagespeed-mod/wiki/Development are failing a clone of git://git.apache.org/apr.git, apr-util, httpd. I've been searching the makefiles but so far haven't stumbled upon a target to run the tests. Is there a simple target to run the unit tests?
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
