hallerm commented on issue #1987: Improve beacon data decoding URL: https://github.com/apache/incubator-pagespeed-mod/pull/1987#issuecomment-612180054 > Also, thanks for looking into the `JSON_USE_EXCEPTION` more closely. I didn't expect it to work like that :-) Should we then also wrap the `parse()` calls? Agreed, it should be assumed that it throws exceptions from all of its functions. I'll push another commit with that and hopefully a test soon. > I went out and updated the jsoncpp dep to the latest, this seems to just work. I'll can look into that separately, as it's fair to say that is of scope here. Good, we are thinking alike on this.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
