wernight edited a comment on pull request #2021:
URL: 
https://github.com/apache/incubator-pagespeed-mod/pull/2021#issuecomment-667248030


   It's true that `html/doc/` is under source control. I think I was looking at 
an older version. Maybe just have an `INSTALL` at the root pointing to 
`html/doc/` directory (not the URL).
   
   Supposing that the current `html/doc/` only needs to be valid for the 
current commit, then why not remote a lot in 
html/doc/build_ngx_pagespeed_from_source.html?
   
   Things that I'd remove:
   
   ```
   -nps_dir=$(find . -name "*pagespeed-ngx-${NPS_VERSION}" -type d)
   +nps_dir=incubator-pagespeed-ngx-${NPS_VERSION}
    cd "$nps_dir"
   -NPS_RELEASE_NUMBER=${NPS_VERSION/beta/}
   -NPS_RELEASE_NUMBER=${NPS_VERSION/stable/}
   
-psol_url=https://dl.google.com/dl/page-speed/psol/${NPS_RELEASE_NUMBER}.tar.gz
   -[ -e scripts/format_binary_url.sh ] && 
psol_url=$(scripts/format_binary_url.sh PSOL_BINARY_URL)
   +psol_url=$(scripts/format_binary_url.sh PSOL_BINARY_URL)
   ```
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to