wernight edited a comment on pull request #2021: URL: https://github.com/apache/incubator-pagespeed-mod/pull/2021#issuecomment-667248030
It's true that `html/doc/build_ngx_pagespeed_from_source.html` is under source control. However I'd have under source control in https://github.com/apache/incubator-pagespeed-ngx maybe just as an `INSTALL` at the root pointing. This way it would only need to be valid for the current commit, then the instructions could be simplified a lot: ``` -nps_dir=$(find . -name "*pagespeed-ngx-${NPS_VERSION}" -type d) +nps_dir=incubator-pagespeed-ngx-${NPS_VERSION} cd "$nps_dir" -NPS_RELEASE_NUMBER=${NPS_VERSION/beta/} -NPS_RELEASE_NUMBER=${NPS_VERSION/stable/} -psol_url=https://dl.google.com/dl/page-speed/psol/${NPS_RELEASE_NUMBER}.tar.gz -[ -e scripts/format_binary_url.sh ] && psol_url=$(scripts/format_binary_url.sh PSOL_BINARY_URL) +psol_url=$(scripts/format_binary_url.sh PSOL_BINARY_URL) ``` ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
