[ 
https://issues.apache.org/jira/browse/PARQUET-395?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15033372#comment-15033372
 ] 

Henrik Baastrup commented on PARQUET-395:
-----------------------------------------

Sounds great with the integration of slf4j.
But in the mean time I think it would be a good idea to drop the log handler 
there use the System.out in the org.apache.parquet.Log, because as is today, a 
user of the library risk to close this stream, without to know it.
If you need any help I'm ready to give a hand.

> System.out is used as logger in org.apache.parquet.Log
> ------------------------------------------------------
>
>                 Key: PARQUET-395
>                 URL: https://issues.apache.org/jira/browse/PARQUET-395
>             Project: Parquet
>          Issue Type: Bug
>    Affects Versions: 1.8.0
>         Environment: parquet-common-1.8.1.jar
>            Reporter: Henrik Baastrup
>
> The use of System.out in the StreamHandler at line 62 in the 
> org.apache.parquet.Log provoke that the java.util.logging.LogManager will 
> close System.out in case the reset method is called on the LogManager.
> This is special problematic when Shutdown Hooks are used in a project, as the 
> LogManager set-up one, there call the reset method, and for this reason a 
> race condition exist on System.out, if used in the project Shutdown Hook.
> Other scenarios might also exist where a program call the LogManager reset 
> method.
> An eventual solution is to NOT use java.util.logging.Logger at all in the 
> Parquet environment but use either log4j or slf4j as used in almost every 
> other part in the Hadoop environment, this would also allow the user to 
> control the logging much better than today.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to