[
https://issues.apache.org/jira/browse/PARQUET-267?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15088856#comment-15088856
]
Kalon Mills commented on PARQUET-267:
-------------------------------------
I have a new
[branch|https://github.com/kalaxy/parquet-cpp/tree/libparquet-library-update-build]
where I rebased my cmake changes from the original pull request off of Wes'
changes. I also removed the thirdparty lz4 code and added support for
downloading it in the download_thirdparty.sh script. This basically keeps the
original sandbox in place while removing and specifics for it from the build
system.
For the final commit, I also pulled thrift into the thirdparty setup scripts.
But I got to wondering, do you think thrift should be provided by the sandbox
scripts? Thrift is pretty finicky to build. So it may to a constant thorn to
try and maintain a script that can build and install it on multiple platforms.
Thrift also has a fair number of dependencies so it complicates describing how
to get a dependencies in order. I wonder what your thoughts are. At a
minimum, I can pull the last commit off and we'd be back to the same sandbox
capabilities as before but with a cleaner build config.
A couple of other things:
* I cleaned up the .travisci a bit because things like g++4.9 weren't actually
getting used. (I tried to get the 4.9 build working for several hours but had
no luck. Maybe another day.)
* In pulling the lz4 directly from github, the api used had to be updated.
Apparently the version used in the committed code was very old.
* Currently the thirdparty scripts still have to use the repo's thirdparty/
directory. I think it would be nicer in the future to move thirdparty
libraries to the actual build directory.
Anyway let me know what you think and if you think this is going in a good
direction.
> Relax Third Party Dependency Restrictions
> -----------------------------------------
>
> Key: PARQUET-267
> URL: https://issues.apache.org/jira/browse/PARQUET-267
> Project: Parquet
> Issue Type: Improvement
> Components: parquet-cpp
> Reporter: Kalon Mills
> Priority: Minor
>
> The existing repo has source code for third party dependencies checked into
> the repo. The build system expects those dependencies in a certain place.
> This enforces that the built library conform to those exact dependencies
> without customization.
> Managing third party dependencies is better handled through a build
> environment. It allows the library builder more flexibility over dependency
> versions and locations. It also cleans up the repo from this third party
> code.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
