Christopher Aycock created PARQUET-744:
------------------------------------------

             Summary: Clarifications on build instructions
                 Key: PARQUET-744
                 URL: https://issues.apache.org/jira/browse/PARQUET-744
             Project: Parquet
          Issue Type: Improvement
          Components: parquet-cpp
            Reporter: Christopher Aycock
            Priority: Minor


Under the direction of [~wesmckinn], I've taken a stab at building Parquet on 
both Mac and Linux. I have a few observations about the build instructions 
found in {{README.md}}.

 - lz4 is listed as a dependency, but {{CMakeLists.txt}} doesn't check for it.
 - zlib is already in macOS, so Homebrew core doesn't have this.
 - {{build_thirdparty.sh}} won't build Thrift on Mac with script, but this 
isn't documented anywhere.
 - The release build option ({{-DCMAKE_BUILD_TYPE=Release}}) isn't listed 
anywhere.

I can make changes if anyone wants.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to